Filling as a good first bug to learn workflows. ``` xpcom/rust/xpcom/xpcom_macros/src/lib.rs 200:17 warning the borrowed expression implements the required traits clippy::needless_borrow (clippy) 361:10 warning this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` clippy::into_iter_on_ref (clippy) ``` Links to the code: https://searchfox.org/mozilla-central/rev/78a2c17cc80680a5a82446e4ce7c45a73b935383/xpcom/rust/xpcom/xpcom_macros/src/lib.rs#200 https://searchfox.org/mozilla-central/rev/78a2c17cc80680a5a82446e4ce7c45a73b935383/xpcom/rust/xpcom/xpcom_macros/src/lib.rs#361 to run clippy: ./mach lint -l clippy xpcom/rust/xpcom/ -W As the change is trivial, it is just to learn how to contribute to Firefox. Tutorial to contribute: https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.
Bug 1868301 Comment 0 Edit History
Note: The actual edited comment in the bug view page will always show the original commenter’s name and original timestamp.
Filling as a good first bug to learn workflows. ``` xpcom/rust/xpcom/xpcom_macros/src/lib.rs 200:17 warning the borrowed expression implements the required traits clippy::needless_borrow (clippy) 361:10 warning this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` clippy::into_iter_on_ref (clippy) ``` Links to the code: https://searchfox.org/mozilla-central/rev/78a2c17cc80680a5a82446e4ce7c45a73b935383/xpcom/rust/xpcom/xpcom_macros/src/lib.rs#200 https://searchfox.org/mozilla-central/rev/78a2c17cc80680a5a82446e4ce7c45a73b935383/xpcom/rust/xpcom/xpcom_macros/src/lib.rs#361 to run clippy: ``` ./mach lint -l clippy xpcom/rust/xpcom/ -W ``` As the change is trivial, it is just to learn how to contribute to Firefox. Tutorial to contribute: https://firefox-source-docs.mozilla.org/contributing/contribution_quickref.html https://firefox-source-docs.mozilla.org/contributing/stack_quickref.html Please don't ask for the bug to be assigned. It will be automatically assigned to the first patch.